Update Delegation01 #1290
Update Delegation01 #1290
Conversation
tgreenx
added
A-TestCase
tgreenx
requested review from
mattias-p,
matsduf,
hannaeko,
a user and
marc-vanderwal
Update some message ids to report name server names and addresses together instead of separately
tgreenx
force-pushed
the
update-delegation01
branch
from
e85d278
to
b9f58a0
Compare
|
I think it would be nice if names resolving to multiple IP addresses could be represented in a less verbose way, and with the IP addresses sorted according to their 32- or 128-bit integer values. For example, instead of having: use this representation: Otherwise, name server names and IP tuples would be excessively hard to read. Especially when IPv6 is involved. |
I think it is uncommon to have multiple IP addresses for the same name server name. The example that you give is a test zone. We should not change anything based on that test zone. If this is to be changed, then it should be specified first so that we do not get an ad-hoc format for one test case. I agree that it can be hard to read when there is a long list of name servers. For GUI I have created an issue with a suggestion to make it easier to digest: zonemaster/zonemaster-gui#315 |
Move name server list to the end of the message ids
Update message ids ENOUGH_NS_DEL and NOT_ENOUGH_NS_DEL
|
@matsduf please re-review |
v2023.2 release testingTested using the "How to test section" and works as expected. |
ghost
added
the
S-ReleaseTested
Since the last release, a few message IDs were changed in Delegation01 (see zonemaster/zonemaster-engine#1290). Instead of having separate {nsname_list} and {ns_ip_list} arguments, these messages now use a merged {ns_list}. After the database migration, looking up results for older tests could cause translated messages to be returned where the {ns_list} placeholder was not substituted, because nothing was done to migrate the nsname_list and ns_ip_list arguments to ns_list. This commit ensures that the messages in question are properly migrated as well. Please note, however, that the name server names and IP addresses are not guaranteed to match (see zonemaster/zonemaster#1203). There is unfortunately no way to recover the correct name server name to IP mapping, so the migration code just assumes that the two lists can be zipped together.
Since the last release, a few message IDs were changed in Delegation01 (see zonemaster/zonemaster-engine#1290). Instead of having separate {nsname_list} and {ns_ip_list} arguments, these messages now use a merged {ns_list}. After the database migration, looking up results for older tests could cause translated messages to be returned where the {ns_list} placeholder was not substituted, because nothing was done to migrate the nsname_list and ns_ip_list arguments to ns_list. This commit ensures that the messages in question are properly migrated as well, for PostgreSQL, MySQL/MariaDB and SQLite. Please note, however, that the name server names and IP addresses are not guaranteed to match (see zonemaster/zonemaster#1203). There is unfortunately no way to recover the correct name server name to IP mapping, so the migration code just assumes that the two lists can be zipped together.
Purpose
This PR updates Delegation01 by updating some message tags/ids to report name server names and addresses together instead of separately.
Context
Fixes zonemaster/zonemaster#1203
Changes
ENOUGH_IPV{4/6}_NS_CHILDNOT_ENOUGH_IPV{4/6}_NS_CHILDENOUGH_IPV{4/6}_NS_DELNOT_ENOUGH_IPV{4/6}_NS_DELENOUGH_NS_{CHILD/DEL}NOT_ENOUGH_NS_{CHILD/DEL}How to test this PR
Unit tests should pass.
Also:
And :
Note that one side effect is that when there is a single name server with several IP addresses, the message might not be obvious at first (counts one name server name, but shows two):